Re: [PATCH 1/8] cherry-pick, revert: add the --gpg-sign option

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Nov 3, 2013, 17:50 UTC
Message-ID: <20131103175015.GA183446@vauxhall.crustytoothpaste.net>
In-Reply-To: <1383494064-5653-2-git-send-email-boklm@mars-attacks.org>

On Sun, Nov 03, 2013 at 04:54:17PM +0100, Nicolas Vigier wrote:

Show 13 quoted lines

> diff --git a/sequencer.h b/sequencer.h
> index 1fc22dcabe13..db43e9cf86dc 100644
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -37,6 +37,8 @@ struct replay_opts {
>  
>  	int mainline;
>  
> +	const char *gpg_sign;
> +
>  	/* Merge strategy */
>  	const char *strategy;
>  	const char **xopts;

One thing you're missing here is the ability to save and retrieve the options. You might be cherry-picking or reverting multiple commits and get interrupted (maybe one is already applied) and need to use --continue.

So populate_options_cb and save_opts need to learn about this sequencer option so that after --continue, commits continue to get signed.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187