Re: [PATCH] sha1_file: move comment about return value where it belongs

From: Jeff King <peff@peff.net>
Date: Oct 28, 2013, 20:19 UTC
Message-ID: <20131028201942.GA21891@sigill.intra.peff.net>
In-Reply-To: <20131026223431.21409.92481.chriscool@tuxfamily.org>

On Sun, Oct 27, 2013 at 12:34:30AM +0200, Christian Couder wrote:

Show 11 quoted lines

> Commit 5b0864070 (sha1_object_info_extended: make type calculation
> optional, Jul 12 2013) changed the return value of the
> sha1_object_info_extended function to 0/-1 for success/error.
> 
> Previously this function returned the object type for success or
> -1 for error. But unfortunately the above commit forgot to change
> or move the comment above this function that says "returns enum
> object_type or negative".
> 
> To fix this inconsistency, let's move the comment above the
> sha1_object_info function where it is still true.

Thanks for catching this. Your analysis and patch looks good to me.

-Peff