git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http.c: Spell the null pointer as NULL

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Oct 24, 2013, 20:58 UTC
Message-ID
<20131024205817.GD9464@google.com>
In-Reply-To
<5269804F.2080800@ramsay1.demon.co.uk>
Ramsay Jones wrote:
Show 6 quoted lines
> Commit 1bbcc224 ("http: refactor options to http_get_*", 28-09-2013)
> changed the type of final 'options' argument of the http_get_file()
> function from an int to an 'struct http_get_options' pointer.
> However, it neglected to update the (single) call site. Since this
> call was passing '0' to that argument, it was (correctly) being
> interpreted as a null pointer. Change to argument to NULL.
Jeff King wrote:
> Thanks, patch is obviously correct (and the cause was just oversight on
> my part).
For what it's worth, against the jk/http-auth-redirects branch,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Ramsay JonesNext: Junio C Hamano
Message 2 of 3 in “http.c: Spell the null pointer as NULL”
  1. http.c: Spell the null pointer as NULLRamsay Jones, Oct 24, 2013
  2. Jonathan NiederOct 24, 2013
  3. Junio C HamanoOct 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.