Re: [PATCH] http: use curl's tcp keepalive if available

From: Jeff King <peff@peff.net>
Date: Oct 15, 2013, 05:00 UTC
Message-ID: <20131015050028.GA8150@sigill.intra.peff.net>
In-Reply-To: <20131015045814.GA12312@dcvr.yhbt.net>

On Tue, Oct 15, 2013 at 04:58:14AM +0000, Eric Wong wrote:

Show 13 quoted lines

> > Subject: http: use curl's tcp keepalive if available
> [...]
> Tested-by: Eric Wong <normalperson@yhbt.net>
> on curl 7.21.0 and 7.26.0, confirmed via strace:
> 
> 	setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, [1], 4) = 0
> 
> I can also confirm 7.26.0 adds:
> 
> 	setsockopt(fd, SOL_TCP, TCP_KEEPIDLE, [60], 4) = 0
> 	setsockopt(fd, SOL_TCP, TCP_KEEPINTVL, [60], 4) = 0
> 
> to the strace on Linux.

Thanks, I didn't actually do any testing myself.

Show 7 quoted lines

> Case 2 works fine on my Debian Squeeze system.
> 
> > Now we have an extra option:
> > 
> >   c. Tell them to upgrade curl. :)
> 
> Yes, I keep forgetting I still have a Debian Squeeze machine :x

I am more concerned with Windows, which may not compile your original patch at all.

-Peff