[PATCH 1/9] http_get_file: style fixes
- From
Jeff King <peff@peff.net>
- Date
- Sep 28, 2013, 08:31 UTC
- Message-ID
- <20130928083059.GA2131@sigill.intra.peff.net>
- In-Reply-To
- <20130928082956.GA22610@sigill.intra.peff.net>
Besides being ugly, the extra parentheses are idiomatic for suppressing compiler warnings when we are assigning within a conditional. We aren't doing that here, and they just confuse the reader.
Signed-off-by: Jeff King <peff@peff.net> --- http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/http.c b/http.c index f3e1439..a985c40 100644 --- a/http.c +++ b/http.c @@ -958,7 +958,7 @@ static int http_get_file(const char *url, const char *filename, int options) strbuf_addf(&tmpfile, "%s.temp", filename); result = fopen(tmpfile.buf, "a"); - if (! result) { + if (!result) { error("Unable to open local file %s", tmpfile.buf); ret = HTTP_ERROR; goto cleanup; @@ -967,7 +967,7 @@ static int http_get_file(const char *url, const char *filename, int options) ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options); fclose(result); - if ((ret == HTTP_OK) && move_temp_to_file(tmpfile.buf, filename)) + if (ret == HTTP_OK && move_temp_to_file(tmpfile.buf, filename)) ret = HTTP_ERROR; cleanup: strbuf_release(&tmpfile);
-- 1.8.4.rc3.19.g9da5bf6