Re: [PATCH] fetch-pack.c: show correct command name that fails

From: Jeff King <peff@peff.net>
Date: Sep 18, 2013, 18:20 UTC
Message-ID: <20130918182052.GB18821@sigill.intra.peff.net>
In-Reply-To: <xmqqvc1yuhao.fsf@gitster.dls.corp.google.com>

On Wed, Sep 18, 2013 at 11:16:15AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> I wondered if this is something we can have a test for easily.
> Unlike the "--upload-pack" option, there is no way for the receiving
> end to choose which index-pack (or unpack-objects) to run, but we
> may force a failure by temporarily futzing with PATH to make a dummy
> git-index-pack that always fails to be found or something silly like
> that.

You can feed a bogus pack, which will cause either to fail reliably. I'm not sure if that counts as "easy" though. :) Munging PATH is probably simpler.

> >  fetch-pack.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)

Patch looks good to me, too.

-Peff