Re: [PATCH] diff: add a config option to control orderfile
On Tue, Sep 17, 2013 at 10:24:19AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > So might it not be useful to tweak patch id to
> > sort the diff, making it a bit more stable?
>
> That is one thing that needs to be done, I think. But it would be
> unfortunate if we have to do that unconditionally, though, as we may
> be "buffering" many hundred kilobytes of patch text in core. If we
> can do so without regressing the streaming performance for the most
> common case of not using the orderfile on the generating side (hence
> not having to sort on the receiving end), it would be ideal. I am
> not sure offhand how much code damage we are talking about, though.
So make it conditional on the presence of the orderefile option?
Show 5 quoted lines
> > I'll be glad to help do this if you tell me what these parts are.
> > anything else besides fixing besides the stand-alone patch id?
>
> Off the top of my head I do not think of one (but that is not a
> guarantee that there isn't any).