Re: [PATCH] http-backend: provide Allow header for 405
On Sun, Sep 08, 2013 at 09:18:12PM -0700, Jonathan Nieder wrote:
Show 26 quoted lines
> > --- a/http-backend.c
> > +++ b/http-backend.c
> > @@ -594,8 +594,11 @@ int main(int argc, char **argv)
> >
> > if (strcmp(method, c->method)) {
> > const char *proto = getenv("SERVER_PROTOCOL");
> > - if (proto && !strcmp(proto, "HTTP/1.1"))
> > + if (proto && !strcmp(proto, "HTTP/1.1")) {
> > http_status(405, "Method Not Allowed");
> > + hdr_str("Allow", !strcmp("GET", c->method) ?
> > + "GET, HEAD" : c->method);
> > + }
> > else
>
> Small style nit: the closing brace should go on the same line as the
> "else", like so:
>
> if (proto && ...) {
> ...
> } else
> http_status(400, "Bad Request");
>
> Another micronit: the comparison should be !strcmp(c->method, "GET")
> --- variable first, then constant it is being compared to.
>
> The functional change looks good.I plan on doing a reroll tomorrow.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
brian m. carlson <sandals@crustytoothpaste.net>