Re: [PATCH v2 2/3] fetch-pack: use index-pack --unpack-limit instead of unpack-objects
- From
Jeff King <peff@peff.net>
- Date
- Sep 8, 2013, 04:45 UTC
- Message-ID
- <20130908044531.GE14019@sigill.intra.peff.net>
- In-Reply-To
- <1378428363-14086-2-git-send-email-pclouds@gmail.com>
On Fri, Sep 06, 2013 at 07:46:02AM +0700, Nguyen Thai Ngoc Duy wrote:
Show 10 quoted lines
> static int get_pack(struct fetch_pack_args *args,
> - int xd[2], char **pack_lockfile)
> + int xd[2], char **pack_lockfile_p)
> {
> struct async demux;
> - const char *argv[22];
> + const char *argv[23];
> char keep_arg[256];
> - char hdr_arg[256];
> + char unpack_limit_arg[256];Perhaps it is time to convert this to use argv_array? I think you could even get rid of the fixed-size buffers, too, with argv_array_pushf().
-Peff