Re: Zero padded file modes...

From: Jeff King <peff@peff.net>
Date: Sep 5, 2013, 19:10 UTC
Message-ID: <20130905191038.GA15910@sigill.intra.peff.net>
In-Reply-To: <alpine.LFD.2.03.1309051302570.14472@syhkavp.arg>

On Thu, Sep 05, 2013 at 01:09:34PM -0400, Nicolas Pitre wrote:

Show 15 quoted lines

> On Thu, 5 Sep 2013, Jeff King wrote:
> 
> > There are basically two solutions:
> > 
> >   1. Add a single-bit flag for "I am 0-padded in the real data". We
> >      could probably even squeeze it into the same integer.
> > 
> >   2. Have a "classic" section of the pack that stores the raw object
> >      bytes. For objects which do not match our expectations, store them
> >      raw instead of in v4 format. They will not get the benefit of v4
> >      optimizations, but if they are the minority of objects, that will
> >      only end up with a slight slow-down.
> 
> That is basically what I just suggested.  But instead of a special 
> section, simply using a special object type number would do it.

Yeah, I think we are in agreement. I only suggested a separate section because I hadn't carefully read the v4 patches yet, and didn't know if there was room in the normal sequence. A special object number seems much more elegant.

-Peff