git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Sep 5, 2013, 06:20 UTC
Message-ID
<20130905062045.GA4197@sandbox-ub>
In-Reply-To
<20130904150853.52EC4121B7E@jed-dev-01.labnet>
Hi,
On Mon, Sep 02, 2013 at 10:54:19AM +0200, Joergen Edelbo wrote:
Show 33 quoted lines
> Problem: It is not possible to push for Gerrit review
> as you will always try to push to /refs/heads/... on
> the remote. As you should not be forced to work on a
> branch with the same name as some branch on the remote,
> some more flexibility in the selection of destination
> branch is also needed.
> 
> Changes done:
> 
> Remove selection of branches to push - push always HEAD.
> This can be justified by the fact that this far the most
> common thing to do.
> Specify both the remote repository to push to as well as
> the specific branch on that remote. This gives the flexibility.
> 
> Add option to specify "Gerrit review". If selected, replace
> the traditional "heads" with the artificial "for" in the
> destination ref spec. This is what actually solved the trigger
> problem.
> 
> Limit the branches to select from to the known branches
> for currently selected remote. This is motivated in better
> usability. Works only when "usettk" is true - it is left for
> further study how to change the values in tk_optionMenu on the
> fly.
> 
> Signed-off-by: Joergen Edelbo <jed@napatech.com>
> ---
> Hi there,
> 
> We are at Napatech A/S just about to roll out a Git/Gerrit/Jenkins
> solution. It will really help the gui oriented people in pushing
> commits if this can be done directly in git-gui.

I like where this is heading. I myself was thinking about this some time ago. Lets include Pat in the CC, since he is the current maintainer of git-gui.

Give me some time to review/testdrive the patch.
Cheers Heiko
Previous: Joergen EdelboNext: Johannes Sixt
Message 2 of 11 in “git-gui: Modify push dialog to support Gerrit review”
  1. git-gui: Modify push dialog to support Gerrit reviewJoergen Edelbo, Sep 2, 2013
  2. Heiko VoigtSep 5, 2013
  3. Johannes SixtSep 5, 2013
  4. Jørgen EdelboSep 5, 2013
  5. Johannes SixtSep 5, 2013
  6. Jørgen EdelboSep 5, 2013
  7. Johannes SixtSep 5, 2013
  8. Junio C HamanoSep 5, 2013
  9. Jørgen EdelboSep 6, 2013
  10. Heiko VoigtSep 5, 2013
  11. Junio C HamanoSep 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.