git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git send-email: include [anything]-by: signatures

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Sep 3, 2013, 21:24 UTC
Message-ID
<20130903212432.GC24480@redhat.com>
In-Reply-To
<20130903210352.GA27344@sigill.intra.peff.net>
On Tue, Sep 03, 2013 at 05:03:52PM -0400, Jeff King wrote:
Show 29 quoted lines
> On Wed, Sep 04, 2013 at 12:01:49AM +0300, Michael S. Tsirkin wrote:
> 
> > > The question of course is the first point Peff raised.  I am not
> > > sure offhand what the right per-project customization interface
> > > would be.  A starting point might be something like:
> > > 
> > > 	--cc-trailer=signed-off-by,acked-by,reviewed-by
> > 
> > tested-by, reported-by ...
> 
> Yeah, I think having the list customizable is nice, but not allowing
> some pattern matching seems unfriendly, as it requires the user to
> enumerate a potentially long list.
> 
> > > 	--cc-trailer='*-by'
> > > 
> > > and an obvious configuration variable that gives the default for it.
> > > That would eventually allow us not to special case any fixed set of
> > > trailers like S-o-b like the current code does, which would be a big
> > > plus.
> > 
> > What bothers me is that git normally uses gawk based patterns,
> > but send-email is in perl so it has a different syntax for regexp.
> > What do you suggest?  Make a small binary to do the matching for us?
> 
> Would fnmatch-style globbing (like "*-by") be enough? That should be
> easy to do in perl.
> 
> -Peff

If you mean only support * - that would be easy. Once you get into bracket expressions it gets messy quickly http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap09.html#tag_09_03_05

-- 
MST
Previous: Jeff KingNext: Junio C Hamano
Message 8 of 10 in “git send-email: include [anything]-by: signatures”
  1. git send-email: include [anything]-by: signaturesMichael S. Tsirkin, Aug 26, 2013
  2. Michael S. TsirkinAug 31, 2013
  3. Jeff KingSep 3, 2013
  4. Michael S. TsirkinSep 3, 2013
  5. Junio C HamanoSep 3, 2013
  6. Michael S. TsirkinSep 3, 2013
  7. Jeff KingSep 3, 2013
  8. Michael S. TsirkinSep 3, 2013
  9. Junio C HamanoSep 3, 2013
  10. Michael S. TsirkinSep 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.