Re: [PATCH] check-ignore: Add option to ignore index contents

From: Adam Spiers <git@adamspiers.org>
Date: Aug 30, 2013, 00:10 UTC
Message-ID: <20130830001054.GA3691@pacific.linksys.moosehall>
In-Reply-To: <20130829224652.GA13621@opensourcesolutions.co.uk>

On Thu, Aug 29, 2013 at 11:46:52PM +0100, Dave Williams wrote:

Show 12 quoted lines

> check-ignore currently shows how .gitignore rules would treat untracked
> paths. Tracked paths do not generate useful output.  This prevents
> debugging of why a path became tracked unexpectedly unless that path is
> first removed from the index with git rm --cached <path>
> 
> This option (-i, --ignore-index) simply by-passes the check for the path
> being in the index and hence allows tracked path to be checked too.
> 
> Whilst this behaviour deviates from the characteristics of git add and
> git status its use case is unlikely to cause any user confusion.
> 
> Signed-off-by: Dave Williams <dave@opensourcesolutions.co.uk>

[snipped]

Sounds like a great idea to me, and the code changes look reasonable; however you forgot to add corresponding tests :-) Please can you expand the patch to include them?

But I'm in favour in principle - thanks a lot for working on this!