Re: [PATCH 2/2] grep: use slash for path delimiter, not colon

From: Jeff King <peff@peff.net>
Date: Aug 26, 2013, 20:52 UTC
Message-ID: <20130826205215.GB23598@sigill.intra.peff.net>
In-Reply-To: <521BB6DA.5050807@kdbg.org>

On Mon, Aug 26, 2013 at 10:13:14PM +0200, Johannes Sixt wrote:

Show 12 quoted lines

> Am 26.08.2013 21:56, schrieb Jeff King:
> > Also, prevent the delimiter being added twice, as happens now in these
> > examples:
> > 
> >   git grep -l foo HEAD:
> >   HEAD::some/path/to/foo.txt
> >        ^
> 
> Which one of these two does it print then?
> 
>     HEAD:/some/path/to/foo.txt
>     HEAD:some/path/to/foo.txt

It should (and does) print the latter.

But I do note that our pathspec handling for subdirectories seems buggy. If you do:

  $ cd Documentation
  $ git grep -l foo | head -1
  RelNotes/1.5.1.5.txt

that's fine; we limit to the current directory. But then if you do:

  $ git grep -l foo HEAD | head -1
  HEAD:RelNotes/1.5.1.5.txt

we still limit to the current directory, but the output does note note this (it should be "HEAD:./RelNotes/1.5.1.5.txt"). I think this bug is orthogonal to Phil's patch, though.

-Peff