Re: Should "git apply --check" imply verbose?

From: Steven Rostedt <rostedt@goodmis.org>
Date: Aug 20, 2013, 19:15 UTC
Message-ID: <20130820151554.6afbcb7f@gandalf.local.home>
In-Reply-To: <xmqqzjsc5ggp.fsf@gitster.dls.corp.google.com>

On Tue, 20 Aug 2013 12:07:18 -0700 Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Paul Gortmaker <paul.gortmaker@windriver.com> writes:
> 
> > OK, so given your feedback, how do you feel about a patch to the
> > documentation that indicates to use "-v" in combination with the
> > "--check" to get equivalent "patch --dry-run" behaviour?   If that
> > had existed, I'd have not gone rummaging around in the source, so
> > that should be good enough to help others avoid the same...
> 
> I do not think it is necessarily a good idea to assume that people
> who are learning "git apply" know how GNU patch works.

Linus told me that "git apply" was basically a replacement for patch. Why would you think it would not be a good idea to assume that people would not be familiar with how GNU patch works?

Is it because you expect "git apply" to eventually replace patch all out, and want no dependencies on its knowledge?

-- Steve

Show 12 quoted lines

> 
> But I do agree that the description of -v, --verbose has a lot of
> room for improvement.
> 
> 	Report progress to stderr. By default, only a message about the
> 	current patch being applied will be printed. This option will cause
> 	additional information to be reported.
> 
> It is totally unclear what "additional information" is reported at
> all.
> 
> Thanks.