Re: [RFC] git-send-email: Cache generated message-ids, use them when prompting

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 18, 2013, 22:24 UTC
Message-ID: <20130818222359.GF64402@vauxhall.crustytoothpaste.net>
In-Reply-To: <7vvc32n1vz.fsf@alter.siamese.dyndns.org>

On Sun, Aug 18, 2013 at 02:08:00PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Rasmus Villemoes <rv@rasmusvillemoes.dk> writes:
> > +# Return an array of cached message-ids, ordered by "relevance". It
> > +# might make sense to take the Subject of the new mail as an extra
> > +# argument and do some kind of fuzzy matching against the old
> > +# subjects, but for now "more relevant" simply means "newer".
> > +sub msgid_cache_getmatches {
> > +	my ($maxentries) = @_;
> > +	$maxentries //= 10;
> 
> The //= operator is mentioned in perl581delta.pod, it seems, and
> none of our Perl scripted Porcelains seems to use it yet.  Is it
> safe to assume that everybody has it?

This operator is new in Perl 5.10. If you want the code to work on RHEL/CentOS 5, you need to avoid it, since they only have 5.8 available.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187