Re: [PATCH] git_mkstemps: improve test suite test

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 3, 2013, 00:36 UTC
Message-ID: <20130803003636.GB2945@elie.Belkin>
In-Reply-To: <201308030027.r730RNWS022924@freeze.ariadne.com>

Hi,

Dale R. Worley wrote:

> Commit 52749 fixes a bug regarding testing the return of an open()

 $ git show 52749
 fatal: ambiguous argument '52749': unknown revision or path not in the working tree.

Could you mention its subject line or date so it's easier to find?

Show 6 quoted lines

> call for success/failure.  Improve the testsuite test for that fix by
> removing the helper program 'test-close-fd-0' and replacing it with
> the shell redirection '<&-'.  (The redirection is Posix, so it should
> be portable.)
> 
> Signed-off-by: Dale Worley <worley@ariadne.com>

[...]

> Someone has gone ahead and made the code change, so all that remains
> is to update the testsuite test by replacing the helper program
> 'test-close-fd-0' with the Posix shell redirection '<&-'.

The above paragraph should be part of the commit message, since otherwise the patch is hard to understand.

The patch text looks good.

Thanks and hope that helps, Jonathan