Re: [PATCH v8 3/4] tests: add new test for the url_normalize function
- From
Jeff King <peff@peff.net>
- Date
- Jul 24, 2013, 19:03 UTC
- Message-ID
- <20130724190356.GA11444@sigill.intra.peff.net>
- In-Reply-To
- <D8BC48D1-195D-4F08-876C-FA592802A12C@gmail.com>
On Wed, Jul 24, 2013 at 12:01:26PM -0700, Kyle J. McKay wrote:
Show 14 quoted lines
> Right now, the values are only available as various strings, ints, > longs etc. which have to be formatted differently for output. The > original string value they were converted from is gone. The snippet > shown above only shows some of the "%s" formatters. > > Either the original value will have to be kept around or a > reconstituted string depending on what: > > git config --file=foo --url http noepsv $URL > > should output. If the original value was 0 or 1, should it output > that or "false" or "true"? The test-url-normalize code for "-c" > normalizes the output to "false" or "true" for all boolean values and > reconverts ints/longs to strings.
I think it would be the responsibility of the caller to specify what they are looking for. I.e., add "--bool" to the git-config command line as appropriate.
-Peff