Re: [PATCH 1/2] git_mkstemps: correctly test return value of open()

From: Dale R. Worley <worley@alum.mit.edu>
Date: Jul 18, 2013, 23:29 UTC
Message-ID: <201307182329.r6INTP7A022917@freeze.ariadne.com>
In-Reply-To: <7vhafr1mhy.fsf@alter.siamese.dyndns.org>

> From: Junio C Hamano <gitster@pobox.com>

Show 9 quoted lines

> > +test_expect_success 'git_mkstemps_mode does not fail if fd 0 is not open' '
> > +	git init &&
> > +	echo Test. >test-file &&
> > +	git add test-file &&
> > +	git commit -m Message. <&-
> > +'
> > +
> 
> Yup.  I wonder how it would fail without the fix, though ;-)

Eh, what? You could run it and see. The test script system will just say "not ok" for this test. If you execute those commands from a shell, you see:

 $ git init
Initialized empty Git repository in /common/not-replicated/worley/temp/1/.git/
 $ echo Test. >test-file
 $ git add test-file
 $ git commit -m Message. <&-
error: unable to create temporary sha1 filename : No such file or directory

error: Error building trees
 $

Dale