Re: [PATCH v4 1/2] git-multimail: an improved replacement for post-receive-email

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 15, 2013, 05:47 UTC
Message-ID: <20130715054734.GC2962@elie.Belkin>
In-Reply-To: <1373789343-3189-2-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

Show 5 quoted lines

> Add git-multimail, a tool for generating notification emails for
> pushes to a Git repository.  It is largely plug-in compatible with
> post-receive-email, and is proposed to eventually replace that script.
> The advantages of git-multimail relative to post-receive-email are
> described in README.migrate-from-post-receive-email.

Yay!

Show 13 quoted lines

>  contrib/hooks/multimail/README                     |  486 ++++
>  contrib/hooks/multimail/README.Git                 |   15 +
>  .../README.migrate-from-post-receive-email         |  146 ++
>  contrib/hooks/multimail/git_multimail.py           | 2394 ++++++++++++++++++++
>  contrib/hooks/multimail/migrate-mailhook-config    |  270 +++
>  contrib/hooks/multimail/post-receive               |   90 +
>  6 files changed, 3401 insertions(+)
>  create mode 100644 contrib/hooks/multimail/README
>  create mode 100644 contrib/hooks/multimail/README.Git
>  create mode 100644 contrib/hooks/multimail/README.migrate-from-post-receive-email
>  create mode 100755 contrib/hooks/multimail/git_multimail.py
>  create mode 100755 contrib/hooks/multimail/migrate-mailhook-config
>  create mode 100755 contrib/hooks/multimail/post-receive

I wouldn't be surprised if it is possible to improve this in some way or other, but where as usual "Reviewed-by" means "If I were maintainer I would commit and push it out and as a non maintainer I vouch for its suitability",

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

The patch integrates it into the git tree sanely and further refinements can safely come on top. Thanks for your hard work.