Re: [PATCH 4/4] diff.c: Do not initialize a variable, which gets reassigned anyway.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 14, 2013, 22:18 UTC
Message-ID: <20130714221848.GE13444@google.com>
In-Reply-To: <1373837749-14402-4-git-send-email-stefanbeller@googlemail.com>

Stefan Beller wrote:

> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
> ---
>  diff.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

[...]

Show 16 quoted lines

> --- a/diff.c
> +++ b/diff.c
> @@ -1677,21 +1677,19 @@ static void show_stats(struct diffstat_t *data, struct diff_options *options)
>  		}
>  
>  		/*
>  		 * scale the add/delete
>  		 */
>  		add = added;
>  		del = deleted;
>  
>  		if (graph_width <= max_change) {
> -			int total = add + del;
> -
> -			total = scale_linear(add + del, graph_width, max_change);
> +			int total = scale_linear(add + del, graph_width, max_change);

Yeah, we should have caught this in review.

Thanks for reporting.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>