git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cache.h: move remote/connect API out of it

From
Jeff King <peff@peff.net>
Date
Jul 9, 2013, 04:21 UTC
Message-ID
<20130709042106.GC27903@sigill.intra.peff.net>
In-Reply-To
<7v1u78zrko.fsf@alter.siamese.dyndns.org>
On Mon, Jul 08, 2013 at 02:09:59PM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> The definition of "struct ref" in "cache.h", a header file so
> central to the system, always confused me.  This structure is not
> about the local ref used by sha1-name API to name local objects.
> [...]
>  * I hate to to this kind of code-movement in the middle of the
>    cycle, but every time I follow the push->transport codepath, I
>    become disoriented by these "struct ref"s.

FWIW, this has often bugged me, too. I did not check what fallouts this will have for series in flight, but in general, I think it is a good thing to be doing.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “cache.h: move remote/connect API out of it”
  1. cache.h: move remote/connect API out of itJunio C Hamano, Jul 8, 2013
  2. Junio C HamanoJul 8, 2013
  3. Jeff KingJul 9, 2013
  4. Junio C HamanoJul 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.