Re: How to still kill git fetch with too many refs

From: Jeff King <peff@peff.net>
Date: Jul 2, 2013, 05:28 UTC
Message-ID: <20130702052827.GA10626@sigill.intra.peff.net>
In-Reply-To: <7vtxkd8rns.fsf@alter.siamese.dyndns.org>

On Mon, Jul 01, 2013 at 10:19:51PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> > Like the patch below, which is built on top of next (which has Junio's
> > prio_queue implementation), and has both the priority queue fix for
> > rev_list_push and the mark_complete sort-at-the-end fix.
> 
> Wow, I saw "160 lines" in my MUA which scared me a bit until I
> opened it to realize 40% is discussion and most of the remaining
> lines are context around single liners.
> 
> It just looks too easy/simple, but the result looks correct, at
> least from a cursory read.
> 
> Good job ;-)

Thanks. :)

I'm splitting it out into readable patches now. At first I was made a bit nervous by the "popping" behavior I described as "oddity #2" earlier. But the more I look at it, the more I am convinced it is simply a bug that we can happen to fix along the way.

Patches in a few minutes.

-Peff