git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do not call built-in aliases from scripts

From
John Keeping <john@keeping.me.uk>
Date
Jun 27, 2013, 18:11 UTC
Message-ID
<20130627181154.GC2232@serenity.lan>
In-Reply-To
<7vmwqbsa3u.fsf@alter.siamese.dyndns.org>
On Thu, Jun 27, 2013 at 11:05:09AM -0700, Junio C Hamano wrote:
Show 33 quoted lines
> John Szakmeister <john@szakmeister.net> writes:
> 
> > On Thu, Jun 27, 2013 at 1:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > [snip]
> >>> diff --git a/git-am.sh b/git-am.sh
> >>> index 9f44509..ad67194 100755
> >>> --- a/git-am.sh
> >>> +++ b/git-am.sh
> >>> @@ -16,8 +16,8 @@ s,signoff       add a Signed-off-by line to the commit message
> >>>  u,utf8          recode into utf8 (default)
> >>>  k,keep          pass -k flag to git-mailinfo
> >>>  keep-non-patch  pass -b flag to git-mailinfo
> >>> -keep-cr         pass --keep-cr flag to git-mailsplit for mbox format
> >>> -no-keep-cr      do not pass --keep-cr flag to git-mailsplit
> >>> independent of am.keepcr
> >>> +keep-cr         pass --keep-cr flag to git mailsplit for mbox format
> >>> +no-keep-cr      do not pass --keep-cr flag to git mailsplit
> >>> independent of am.keepcr
> >>>  c,scissors      strip everything before a scissors line
> >>>  whitespace=     pass it through git-apply
> >>>  ignore-space-change pass it through git-apply
> >>
> >>> As you were saying yourself, we tell users to prefer the "git foo"
> >>> form, so we should also do so in the "git am" option help, IMHO.
> >>
> >> What does the above change to the options-help have anything to do
> >> with that theme?  It does not seem to say anything about "git foo"
> >> vs "git-foo"?
> >
> > I initially missed it too, but `git-mailsplit` changed to `git
> > mailsplit` in the help.
> 
> Ahh, OK.

That is rendered differently though, I don't think just having the plain text git command is as useful. It should either use the hyphenated form or enclose the text in quotes.

Previous: Sebastian SchuberthNext: Johannes Schindelin
Message 9 of 14 in “Do not call built-in aliases from scripts”
  1. Do not call built-in aliases from scriptsSebastian Schuberth, Jun 27, 2013
  2. Junio C HamanoJun 27, 2013
  3. Sebastian SchuberthJun 27, 2013
  4. Junio C HamanoJun 27, 2013
  5. John SzakmeisterJun 27, 2013
  6. Junio C HamanoJun 27, 2013
  7. Junio C HamanoJun 27, 2013
  8. Sebastian SchuberthJun 28, 2013
  9. John KeepingJun 27, 2013
  10. Johannes SchindelinJun 27, 2013
  11. Sebastian SchuberthJun 28, 2013
  12. Johannes SchindelinJun 28, 2013
  13. Junio C HamanoJun 28, 2013
  14. Johannes SixtJun 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.