git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix "builtin-*" references to be "builtin/*"

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 18, 2013, 16:28 UTC
Message-ID
<20130618162823.GB2887@elie.Belkin>
In-Reply-To
<1371571166-6481-1-git-send-email-hordp@cisco.com>
Hi,
Phil Hord wrote:
> Documentation and some comments still refer to files in builtin/
> as 'builtin-*.[cho]'.  Update these to show the correct location.
Yeah, good call.
[...]
Show 7 quoted lines
> --- a/builtin/help.c
> +++ b/builtin/help.c
> @@ -1,5 +1,5 @@
>  /*
> - * builtin-help.c
> + * builtin/help.c
>   *

It would probably be better to remove the above two lines which are redundant next to the filename. That can wait for a later patch if you like, though.

With or without that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Phil HordNext: Junio C Hamano
Message 2 of 3 in “fix "builtin-*" references to be "builtin/*"”
  1. fix "builtin-*" references to be "builtin/*"Phil Hord, Jun 18, 2013
  2. Jonathan NiederJun 18, 2013
  3. Junio C HamanoJun 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.