Re: [PATCH] format-patch: remove existing output-directory
- From
Fredrik Gustafsson <iveqy@iveqy.com>
- Date
- Jun 14, 2013, 13:16 UTC
- Message-ID
- <20130614131629.GA1086@paksenarrion.iveqy.com>
- In-Reply-To
- <1371213813-7925-1-git-send-email-artagnon@gmail.com>
Hi, just some questions about your patch.
On Fri, Jun 14, 2013 at 06:13:33PM +0530, Ramkumar Ramachandra wrote:
Show 8 quoted lines
> The following command > > $ git format-patch -o outgoing master > > does not ensure that the output-directory outgoing doesn't already > exist. As a result, it's possible for patches from two different series > to get mixed up if the user is not careful. Fix the problem by > unconditionally removing the output-directory before writing to it.
I'm not entirely happy about removing untracked stuff without asking the user. What if the output directory isn't empty? What if a user just want them in ~?
However I think this patch can improve the workflow for experienced developers. Can we tweak this in some way to get the best out of both worlds?
Show 6 quoted lines
> + struct strbuf buf = STRBUF_INIT;
> +
> if (use_stdout)
> die(_("standard output, or directory, which one?"));
> + strbuf_addstr(&buf, output_directory);
> + remove_dir_recursively(&buf, 0);Should we have a strbuf_release here?
-- Med vänliga hälsningar Fredrik Gustafsson tel: 0733-608274 e-post: iveqy@iveqy.com