Re: [PATCH/RFC] git-remote-mediawiki: new tool to preview local changes without pushing

From: Jeff King <peff@peff.net>
Date: Jun 12, 2013, 08:55 UTC
Message-ID: <20130612085502.GA1935@sigill.intra.peff.net>
In-Reply-To: <vpqli6f24z3.fsf@anie.imag.fr>

On Wed, Jun 12, 2013 at 08:55:12AM +0200, Matthieu Moy wrote:

Show 9 quoted lines

> > But I think we have already crossed that bridge somewhat with Git.pm.
> > And if you add your module as perl/Git/MediaWiki.pm and use the existing
> > perl build system, then it is not any extra effort from the build
> > system.
> 
> I'm not sure having perl/Git/MediaWiki.pm would be a good idea: this
> MediaWiki.pm would be really a mediawiki thing more than a Git thing, so
> the Git main tree probably want to stay away from it and keep it in
> contrib.

Yes, it's ugly. It means that the mediawiki stuff creeps out of contrib and into the main tree; and worse, as part of a public API that gets installed. We'd have to be a lot more picky about the interface and the code quality.

> But you should be able to use contrib/mw-to-git/perl/GitMediawiki.pm or
> something like that and chain to ../../perl/Makefile in
> contrib/mw-to-git/Makefile.

That might work. Most of the magic in perl/Makefile happens in the perl-generated MakeMaker bits, though, so it may not be that easy. I haven't looked.

> Also, for now, git-remote-mediawiki works only after you run "make
> install" in Git's toplevel. I think that's ok, but it would be weird to
> be able to use/test git-remote-mediawiki only after doing a "make
> install" to deploy the new mediawiki Perl module.

Good point.

-Peff