git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaround

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 10, 2013, 00:09 UTC
Message-ID
<20130610000954.GA6464@elie.Belkin>
In-Reply-To
<1370822361-15637-1-git-send-email-szeder@ira.uka.de>
SZEDER Gábor wrote:
Show 9 quoted lines
> Fedore 9 shipped the gvfs package with a buggy Bash completion script:
> it removed the ':' character from COMP_WORDBREAKS, thereby breaking
> certain features of git's completion script.  We worked this around in
> db8a9ff0 (bash completion: Resolve git show ref:path<tab> losing ref:
> portion, 2008-07-15).
>
> The bug was fixed in Fedora 10 and Fedora 9 reached its EOL on
> 2009-07-10, almost four years ago.  It's about time to remove our
> workaround.

Nice! I had wondered what that workaround was about but never ended up digging into it.

Searching for COMP_WORDBREAKS in /etc/bash_completion.d/* finds similar breakage (removal of '=' and '@') in the npm completion script, but nothing involving colon. So this looks like a good change.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: SZEDER GáborNext: SZEDER Gábor
Message 2 of 5 in “completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaround”
  1. completion: remove ancient "ensure colon in COMP_WORDBREAKS" workaroundSZEDER Gábor, Jun 9, 2013
  2. Jonathan NiederJun 10, 2013
  3. SZEDER GáborJun 10, 2013
  4. Junio C HamanoJun 10, 2013
  5. Eric SunshineJun 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.