Re: [PATCH] describe: Add --left-only option

From: Mike Crowe <mac@mcrowe.com>
Date: May 17, 2013, 15:16 UTC
Message-ID: <20130517151623.GA3083@mcrowe.com>
In-Reply-To: <20130517150329.GA27005@serenity.lan>

On Fri, May 17, 2013 at 04:03:29PM +0100, John Keeping wrote:

Show 9 quoted lines

> On Fri, May 17, 2013 at 03:24:26PM +0100, Mike Crowe wrote:
> > Only consider the first parent commit when walking the commit history. This
> > is useful if you only wish to match tags on your branch after a merge.
> 
> For consistency with "git log" should this be called "--first-parent"?
> 
> In "git log" --left-only takes effect only when considering a symmetric
> range, which "git describe" isn't.  Whereas --first-parent triggers
> precisely the behaviour described here.

I think you're right.

I'm happy to rename it and resubmit if the rest of the patch passes muster.

Thanks.

Mike.