Re: [PATCH] gitk: simplify file filtering

From: Paul Mackerras <paulus@samba.org>
Date: May 13, 2013, 00:36 UTC
Message-ID: <20130513003602.GA8046@iris.ozlabs.ibm.com>
In-Reply-To: <7vmwrzu7vt.fsf@alter.siamese.dyndns.org>

On Sun, May 12, 2013 at 03:54:14PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Paul Mackerras <paulus@samba.org> writes:
> 
> > On Sat, Apr 27, 2013 at 05:01:39PM -0500, Felipe Contreras wrote:
> >> git diff is perfectly able to do this with '-- files', no need for
> >> manual filtering.
> >> 
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Thanks, applied, with the commit message expanded to say that this
> > makes gettreediffs do the same as getblobdiffs.
> >
> > Paul.
> 
> Thanks; is this the last one for this cycle and is your usual branch
> ready to be pulled?

I'm still deciding whether to put in Martin Langhoff's patch with a modified label ("changing lines matching" rather than "with changes matching regex"). I'm leaning towards it but was waiting a little to see if anyone had comments on the wording. I'll decide by the end of today and send you a pull request either way.

Thanks, Paul.