git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH v3 4/5] teach config --blob option to parse config from database

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
May 10, 2013, 15:47 UTC
Message-ID
<20130510154735.GA3850@book-mint>
In-Reply-To
<20130509223038.GB30774@sigill.intra.peff.net>
On Fri, May 10, 2013 at 12:30:39AM +0200, Jeff King wrote:
Show 13 quoted lines
> On Thu, May 09, 2013 at 06:20:18PM +0200, Heiko Voigt wrote:
> 
> > +static int config_buf_fgetc(struct config_source *conf)
> > +{
> > +	if (conf->buf.pos < conf->buf.len && conf->buf.buf[conf->buf.pos])
> > +		return conf->buf.buf[conf->buf.pos++];
> > +
> > +	return EOF;
> > +}
> 
> It probably would not matter for config reading, but is there any reason
> not to make your fgetc replacement 8-bit clean (i.e., to check only len,
> and not worry about NUL characters)?

I got a NULL character here and by mistake thought that somehow the len would include the ending character. But that was a bug introduced by me when I refactored to buffer and length instead of strbuf. I missed to transport the len properly. So I will removed this check again.

Cheers Heiko
Previous: Jeff KingNext: Heiko Voigt
Message 8 of 14 in “config: factor out config file stack management”
  1. 1/5 config: factor out config file stack managementHeiko Voigt, May 9, 2013
  2. 2/5 config: drop cf validity check in get_next_char()Heiko Voigt, May 9, 2013
  3. 3/5 config: make parsing stack struct independent from actual data sourceHeiko Voigt, May 9, 2013
  4. Jeff KingMay 9, 2013
  5. 4/5 teach config --blob option to parse config from databaseHeiko Voigt, May 9, 2013
  6. Eric SunshineMay 9, 2013
  7. Jeff KingMay 9, 2013
  8. Heiko VoigtMay 10, 2013
  9. 5/5 do not die when error in config parsing of buf occursHeiko Voigt, May 9, 2013
  10. Eric SunshineMay 9, 2013
  11. Jeff KingMay 9, 2013
  12. Heiko VoigtMay 11, 2013
  13. Jeff KingMay 11, 2013
  14. Heiko VoigtMay 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.