git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] deprecate core.statinfo at Git 2.0 boundary

From
Jeff King <peff@peff.net>
Date
May 7, 2013, 14:09 UTC
Message-ID
<20130507140904.GA3282@sigill.intra.peff.net>
In-Reply-To
<7v1u9jnyox.fsf_-_@alter.siamese.dyndns.org>
On Mon, May 06, 2013 at 10:31:10PM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> c08e4d5b5cfa (Enable minimal stat checking, 2013-01-22) advertised
> the configuration variable core.checkstat in the documentation and
> its log message, but the code expected core.statinfo instead.
> 
> For now, add core.checkstat, and warn people who have core.statinfo
> in their configuration file that we will remove it in Git 2.0.
Yeah, that looks like a fine solution to me.

To be honest, I doubt that it is even necessary to handle the backwards compatibility. The checkstat option never actually worked, statinfo was never advertised, and the broken state was available in only one release. So I'd be very surprised if anyone more than the author was actually using it.

Still, it is not that hard to handle both, so I suppose it is better to be conservative.

-Peff
Previous: Junio C HamanoNext: Robin Rosenberg
Message 26 of 29 in “Perform minimal stat comparison when some stat fields are not set”
  1. Perform minimal stat comparison when some stat fields are not setRobin Rosenberg, Dec 5, 2012
  2. Junio C HamanoDec 5, 2012
  3. Robin RosenbergDec 6, 2012
  4. Johannes SixtDec 6, 2012
  5. Robin RosenbergDec 6, 2012
  6. Make git selectively and conditionally ignore certain stat fieldsRobin Rosenberg, Jan 14, 2013
  7. Junio C HamanoJan 14, 2013
  8. Robin RosenbergJan 14, 2013
  9. Junio C HamanoJan 15, 2013
  10. Robin RosenbergJan 15, 2013
  11. Johannes SixtJan 15, 2013
  12. Robin RosenbergJan 15, 2013
  13. Junio C HamanoJan 15, 2013
  14. Ramsay JonesJan 16, 2013
  15. Robin RosenbergJan 20, 2013
  16. Junio C HamanoJan 20, 2013
  17. Enable minimal stat checkingRobin Rosenberg, Jan 22, 2013
  18. Johannes SixtJan 22, 2013
  19. Torsten BögershausenJan 22, 2013
  20. Junio C HamanoJan 22, 2013
  21. Robin RosenbergJan 22, 2013
  22. Jeff KingMay 6, 2013
  23. Junio C HamanoMay 7, 2013
  24. deprecate core.statinfo at Git 2.0 boundaryJunio C Hamano, May 7, 2013
  25. Junio C HamanoMay 7, 2013
  26. Jeff KingMay 7, 2013
  27. Robin RosenbergMay 7, 2013
  28. Make git selectively and conditionally ignore certain stat fieldsRobin Rosenberg, Jan 14, 2013
  29. Junio C HamanoJan 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.