[PATCH] test-lint-shell-syntax: Allow bash syntax in bash tests

From

Torsten Bögershausen <tboegi@web.de>

Date

Apr 25, 2013, 18:48 UTC

Message-ID

<201304252048.33803.tboegi@web.de>

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 t/check-non-portable-shell.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index 58f8e2c..1ca8c8b 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -7,23 +7,26 @@ use strict;
 use warnings;
 
 my $exit_code=0;
+my $bashmode=0;
 
 sub err {
 	my $msg = shift;
-	print "$ARGV:$.: error: $msg: $_\n";
+	print "$ARGV:$.: error: (bashmode=$bashmode) $msg: $_\n";
 	$exit_code = 1;
 }
 
 while (<>) {
 	chomp;
+	/^\. \.\/lib\-bash.sh/ and $bashmode=1;
 	/ e?grep\s+\"[^"]*\\([st])/ and err "grep \\$1 is not portable)";
 	/ [^e]grep.*\\\+/ and err 'grep with \+ is not portable (please use egrep)';
 	/^\s*sed\s+-i/ and err 'sed -i is not portable';
 	/^\s*echo\s+-(\S)\s+/ and err "echo -$1 is not portable (please use printf)";
 	/^\s*declare\s+/ and err 'arrays/declare not portable';
 	/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
-	/test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
+	$bashmode==0 and /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
 	# this resets our $. for each file
 	close ARGV if eof;
+	$bashmode=0 if eof;
 }
 exit $exit_code;

-- 
1.8.2.1.614.g66d7af5