[PATCH] check-non-portable-shell: echo -e is not portable
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Apr 25, 2013, 18:48 UTC
- Message-ID
- <201304252048.04553.tboegi@web.de>
Depending on the implementation, the echo command may support options like -n -e -E or no options at all.
The only portable usage of echo is without any options, which means that no parameter may start with a hyphen.
check-non-portable-shell.pl checks if echo -n is used. Improve it to reject any parameter starting with a hyphen and recommend the usage of printf instead
Signed-off-by: Torsten Bögershausen <tboegi@web.de> --- t/check-non-portable-shell.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl index 8b5a71d..ff87611 100755 --- a/t/check-non-portable-shell.pl +++ b/t/check-non-portable-shell.pl @@ -17,7 +17,7 @@ sub err { while (<>) { chomp; /^\s*sed\s+-i/ and err 'sed -i is not portable'; - /^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)'; + /^\s*echo\s+-(\S)\s+/ and err "echo -$1 is not portable (please use printf)"; /^\s*declare\s+/ and err 'arrays/declare not portable'; /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)'; /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
-- 1.8.2.1.614.g66d7af5