Re: Fwd: [PATCH] git-svn: added an --include-path flag

From: Eric Wong <normalperson@yhbt.net>
Date: Apr 24, 2013, 21:28 UTC
Message-ID: <20130424212856.GA23696@dcvr.yhbt.net>
In-Reply-To: <CAHpQJx0iT_+pOzdEJ-uyn7GjkXs8ZwhfPoMYpQDxwAB5mQ1xrw@mail.gmail.com>

Paul Walmsley <pjwhams@gmail.com> wrote:

Show 8 quoted lines

> Hi,
> Please forgive the direct approach, but I submitted a git-svn patch to the
> git list which sank without any comment. As major contributors to git-svn I
> would like to solicit your feedback on it. The patch is so that git svn
> clone supports '--include-path' as a complement to '--ignore-path'.  I had
> a need for this as our SVN repository has many top level folders of which
> only a few may be needed for any project.  I wanted to contribute the patch
> back as I think it may be useful to others. I've included unit tests too.

No forgivness necessary, it's standard practice to Cc maintainers in git (and Linux kernel) patch submissions :)

(Re-adding git ML-as Cc)

Show 7 quoted lines

> --- /dev/null
> +++ b/t/t9147-git-svn-include-paths.sh
> @@ -0,0 +1,150 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2009 Vitaly Shukela
> +# Copyright (c) 2009 Eric Wong

Use your name (and current year) in copyright headers for your submissions.

I'll take a closer look at the rest of the patch later, but your patch below appears line-wrapped and mangled (see Documentation/SubmittingPatches).

Also, we'd greatly appreciate you omit HTML from emails in the future.

Thanks.