Re: segfault in git-remote-http

From: rh <richard_hubbe11@lavabit.com>
Date: Apr 9, 2013, 17:41 UTC
Message-ID: <20130409104134.a9a42b74ec33b3147cd45c81@lavabit.com>
In-Reply-To: <20130409171623.GE21972@sigill.intra.peff.net>

On Tue, 9 Apr 2013 13:16:23 -0400 Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

> On Tue, Apr 09, 2013 at 08:47:18AM -0700, rh wrote:
> 
> > The symptoms that this patch addresses look similar:
> > 
> > http://article.gmane.org/gmane.mail.postfix.user/217790
> > 
> > Quote from that thread:
> > "This behavior is actually documented (SSL_set_fd() destroys
> > a BIO already on the SSL handle, and creates a new BIO)."
> > 
> > Maybe someone used to looking at git-remote-http code can
> > say anything about this.
> 
> git-remote-http does not touch the openssl code itself at all. We only
> talk to curl, which handles all of the ssl (and may even be built on
> gnutls). So if that is the problem, then I think it may be a libcurl
> bug, not a git one.

Thanks, I see git-remote-{http,https,ftp,ftps} are the same size. Minor nitpick but shouldn't the error thrown say git-remote-https?