Re: [PATCH 2/2] clone: Allow repo using gitfile as a reference

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 7, 2013, 23:51 UTC
Message-ID: <20130407235112.GH19857@elie.Belkin>
In-Reply-To: <1365376629-16054-2-git-send-email-aaron@schrab.com>

Aaron Schrab wrote:

Show 8 quoted lines

> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -231,12 +231,19 @@ static void strip_trailing_slashes(char *dir)
>  
>  static int add_one_reference(struct string_list_item *item, void *cb_data)
>  {
> -	char *ref_git;
> +	char *ref_git, *repo;

[...]

> +	repo = (char *)read_gitfile(mkpath("%s/.git", ref_git));

Why not make repo a "const char *" and avoid the cast? The above would seem to make it too tempting to treat the return value from read_gitfile() as a mutable buffer instead of a real_path string that should be copied asap.

Hope that helps, Jonathan