git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] branch: factor out "upstream is not a branch" error messages

From
Jeff King <peff@peff.net>
Date
Apr 2, 2013, 19:03 UTC
Message-ID
<20130402190355.GB32316@sigill.intra.peff.net>
In-Reply-To
<20130402190134.GA17784@sigill.intra.peff.net>

This message is duplicated, and is quite long. Let's factor it out, which avoids the repetition and the long lines. It will also make future patches easier as we tweak the message.

While we're at it, let's also mark it for translation.
Signed-off-by: Jeff King <peff@peff.net>
---
 branch.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/branch.c b/branch.c
index 2bef1e7..1acbd4e 100644
--- a/branch.c
+++ b/branch.c
@@ -197,6 +197,9 @@ int validate_new_branchname(const char *name, struct strbuf *ref,
 	return 1;
 }
 
+static const char upstream_not_branch[] =
+N_("Cannot setup tracking information; starting point is not a branch.");
+
 void create_branch(const char *head,
 		   const char *name, const char *start_name,
 		   int force, int reflog, int clobber_head,
@@ -231,14 +234,14 @@ void create_branch(const char *head,
 	case 0:
 		/* Not branching from any existing branch */
 		if (explicit_tracking)
-			die("Cannot setup tracking information; starting point is not a branch.");
+			die(_(upstream_not_branch));
 		break;
 	case 1:
 		/* Unique completion -- good, only if it is a real branch */
 		if (prefixcmp(real_ref, "refs/heads/") &&
 		    prefixcmp(real_ref, "refs/remotes/")) {
 			if (explicit_tracking)
-				die("Cannot setup tracking information; starting point is not a branch.");
+				die(_(upstream_not_branch));
 			else
 				real_ref = NULL;
 		}
-- 
1.8.2.rc0.33.gd915649
Previous: Jeff KingNext: Garrett Cooper
Message 7 of 15 in “[BUG] inconsistent behavior with --set-upstream vs --set-upstream-to”
  1. Garrett CooperApr 2, 2013
  2. Jeff KingApr 2, 2013
  3. Garrett CooperApr 2, 2013
  4. Jeff KingApr 2, 2013
  5. 0/5 branch --set-upstream-to error-message improvementsJeff King, Apr 2, 2013
  6. 1/5 t3200: test --set-upstream-to with bogus refsJeff King, Apr 2, 2013
  7. 2/5 branch: factor out "upstream is not a branch" error messagesJeff King, Apr 2, 2013
  8. Garrett CooperApr 2, 2013
  9. Garrett CooperApr 2, 2013
  10. 3/5 branch: improve error message for missing --set-upstream-to refJeff King, Apr 2, 2013
  11. 4/5 branch: mention start_name in set-upstream error messagesJeff King, Apr 2, 2013
  12. Garrett CooperApr 2, 2013
  13. 5/5 branch: give advice when tracking start-point is missingJeff King, Apr 2, 2013
  14. Junio C HamanoApr 2, 2013
  15. Jonathan NiederApr 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.