Re: [Patch] gitk: added a file history browser
- From
Paul Mackerras <paulus@samba.org>
- Date
- Apr 1, 2013, 07:24 UTC
- Message-ID
- <20130401072408.GB4427@iris.ozlabs.ibm.com>
- In-Reply-To
- <0063A4B3-8C79-4F2F-97C7-D14AEBB17DEC@freunde-aus-berlin.net>
On Wed, Feb 20, 2013 at 12:14:20AM +0100, Dirk wrote:
> Hi, > > I added a file history browser for a single file in the gitk. I use git log with the option --follow. This option is useful for the user switch from cvs to git. He misses a history from only one file and the function "Highlight this only" breaks by moved files. The new option do not break by the moved files. I use ideas from the tkcvs branch dialog.
How is this better than running "gitk --follow -- file"?
Also, it's rather a large patch with only a two-line patch description, which is not really adequate. And it's missing a Signed-off-by.
I think the right way to do this is to have the file menu option create a new view specifying the file and the --follow option, rather than creating a whole new window.
Paul.