git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1300: document some aesthetic failures of the config editor

From
Jeff King <peff@peff.net>
Date
Mar 30, 2013, 00:21 UTC
Message-ID
<20130330002139.GA32353@sigill.intra.peff.net>
In-Reply-To
<7vvc8alzat.fsf@alter.siamese.dyndns.org>
On Fri, Mar 29, 2013 at 01:35:22PM -0700, Junio C Hamano wrote:
Show 23 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Here it is with the updated expectation. I don't care _that_ much, so if
> > you feel strongly and want to drop the first test, feel free.
> 
> As long as we are adding expect_failure without an immediate fix,
> let's document the ideal, with this patch on top.
> [...]
>  test_expect_failure 'unsetting the last key in a section removes header' '
>  	cat >.git/config <<-\EOF &&
> +	# some generic comment on the configuration file itself
> +	# a comment specific to this "section" section.
>  	[section]
>  	# some intervening lines
>  	# that should also be dropped
>  
>  	key = value
>  	EOF
>  
> -	>expect &&
> +	cat >expect <<-\EOF &&
> +	# some generic comment on the configuration file itself
> +	EOF

I think we may not attain that ideal without some natural language processing of the comments. But hey, no reason not to shoot for the stars. :)

-Peff
Previous: Junio C HamanoNext: Johannes Schindelin
Message 9 of 13 in “Minor bug in git branch --set-upstream-to adding superfluous branch section to config”
  1. Phil HaackMar 29, 2013
  2. Jeff KingMar 29, 2013
  3. Thomas RastMar 29, 2013
  4. Jeff KingMar 29, 2013
  5. t1300: document some aesthetic failures of the config editorJeff King, Mar 29, 2013
  6. Junio C HamanoMar 29, 2013
  7. Jeff KingMar 29, 2013
  8. Junio C HamanoMar 29, 2013
  9. Jeff KingMar 30, 2013
  10. Johannes SchindelinMar 28, 2018
  11. Jeff KingMar 28, 2018
  12. Junio C HamanoMar 29, 2013
  13. Junio C HamanoMar 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.