Re: [PATCH] t1300: document some aesthetic failures of the config editor
- From
Jeff King <peff@peff.net>
- Date
- Mar 30, 2013, 00:21 UTC
- Message-ID
- <20130330002139.GA32353@sigill.intra.peff.net>
- In-Reply-To
- <7vvc8alzat.fsf@alter.siamese.dyndns.org>
On Fri, Mar 29, 2013 at 01:35:22PM -0700, Junio C Hamano wrote:
Show 23 quoted lines
> Jeff King <peff@peff.net> writes: > > > Here it is with the updated expectation. I don't care _that_ much, so if > > you feel strongly and want to drop the first test, feel free. > > As long as we are adding expect_failure without an immediate fix, > let's document the ideal, with this patch on top. > [...] > test_expect_failure 'unsetting the last key in a section removes header' ' > cat >.git/config <<-\EOF && > + # some generic comment on the configuration file itself > + # a comment specific to this "section" section. > [section] > # some intervening lines > # that should also be dropped > > key = value > EOF > > - >expect && > + cat >expect <<-\EOF && > + # some generic comment on the configuration file itself > + EOF
I think we may not attain that ideal without some natural language processing of the comments. But hey, no reason not to shoot for the stars. :)
-Peff