Re: Bug in "git rev-parse --verify"

From: Jeff King <peff@peff.net>
Date: Mar 28, 2013, 16:38 UTC
Message-ID: <20130328163848.GA7194@sigill.intra.peff.net>
In-Reply-To: <5154672F.10303@alum.mit.edu>

On Thu, Mar 28, 2013 at 04:52:15PM +0100, Michael Haggerty wrote:

Show 14 quoted lines

> On 03/28/2013 04:38 PM, Jeff King wrote:
> > On Thu, Mar 28, 2013 at 04:34:19PM +0100, Michael Haggerty wrote:
> > 
> >> Is there a simple way to verify an object name more strictly and convert
> >> it to an SHA1?  I can only think of solutions that require two commands,
> >> like
> >>
> >>     git cat-file -e $ARG && git rev-parse --verify $ARG
> > 
> > Is the rev-parse line doing anything there? If $ARG does not resolve to
> > a sha1, then wouldn't cat-file have failed?
> 
> It's outputting the SHA1, which cat-file seems incapable of providing in
> a useful way.

Ah, I see; I was looking too much at your example, and not thinking about how you would want to use it in a script.

-Peff