Re: [PATCH 1/6] remote.c: simplify a bit of code using git_config_string()
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 20, 2013, 18:07 UTC
- Message-ID
- <20130320180707.GH3655@google.com>
- In-Reply-To
- <1363783501-27981-2-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
Show 10 quoted lines
> --- a/remote.c
> +++ b/remote.c
> @@ -356,9 +356,7 @@ static int handle_config(const char *key, const char *value, void *cb)
> return 0;
> branch = make_branch(name, subkey - name);
> if (!strcmp(subkey, ".remote")) {
> - if (!value)
> - return config_error_nonbool(key);
> - branch->remote_name = xstrdup(value);
> + git_config_string(&branch->remote_name, key, value);Shouldn't this say
if (git_config_string(&branch->remote_name, key, value)) return -1;
or something?
Thanks, Jonathan