git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] http_init: only initialize SSL for https

From
Jeff King <peff@peff.net>
Date
Mar 16, 2013, 12:03 UTC
Message-ID
<20130316120300.GA2626@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.00.1303151719170.32216@tvnag.unkk.fr>
On Fri, Mar 15, 2013 at 05:23:27PM +0100, Daniel Stenberg wrote:
Show 10 quoted lines
> >Thanks, then we should stick to starting from ALL like everybody
> >else who followed the suggestion in the documentation.  Do you have
> >recommendations on the conditional dropping of SSL?
> 
> Not really, no.
> 
> SSL initing is as has been mentioned alredy only relevant with
> libcurl if an SSL powered protocol is gonna be used, so if checking
> the URL for the protocol is enough to figure this out then sure that
> should work fine.

But are we correct in assuming that curl will barf if it gets a redirect to an ssl-enabled protocol? My testing seems to say yes:

  [in one terminal]
  $ nc -lCp 5001 <<\EOF
  HTTP/1.1 301
  Location: https://github.com/peff/git.git
  EOF
  [in another, git compiled with Erik's patch]
  $ git ls-remote http://localhost:5001
  error: SSL: couldn't create a context: error:140A90A1:lib(20):func(169):reason(161) while accessing http://localhost:5001/info/refs?service=git-upload-pack
  fatal: HTTP request failed
-Peff
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Previous: Daniel StenbergNext: Daniel Stenberg
Message 12 of 21 in “http_init: only initialize SSL for https”
  1. http_init: only initialize SSL for httpsErik Faye-Lund, Mar 14, 2013
  2. Erik Faye-LundMar 14, 2013
  3. Johannes SchindelinMar 14, 2013
  4. Erik Faye-LundMar 14, 2013
  5. Junio C HamanoMar 14, 2013
  6. Johannes SchindelinMar 14, 2013
  7. Junio C HamanoMar 14, 2013
  8. Erik Faye-LundMar 14, 2013
  9. Daniel StenbergMar 15, 2013
  10. Junio C HamanoMar 15, 2013
  11. Daniel StenbergMar 15, 2013
  12. Jeff KingMar 16, 2013
  13. Daniel StenbergMar 16, 2013
  14. Antoine PelisseMar 17, 2013
  15. Daniel StenbergMar 17, 2013
  16. Junio C HamanoMar 17, 2013
  17. Erik Faye-LundMar 18, 2013
  18. Erik Faye-LundMar 18, 2013
  19. Junio C HamanoMar 14, 2013
  20. Johannes SchindelinMar 14, 2013
  21. Junio C HamanoMar 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.