Re: Memory corruption when rebasing with git version 1.8.1.5 on arch

From: Jeff King <peff@peff.net>
Date: Mar 11, 2013, 05:18 UTC
Message-ID: <20130311051840.GB13510@sigill.intra.peff.net>
In-Reply-To: <513C7267.2090608@bernhard-posselt.com>

On Sun, Mar 10, 2013 at 12:45:43PM +0100, Bernhard Posselt wrote:

Show 6 quoted lines

> >   valgrind -q --trace-children=yes --log-file=/tmp/valgrind.out \
> >     git pull --rebase https://github.com/Raydiation/core
> 
> The log file was empty and it seemed to apply everything nice when
> running valgrind. When i tried to run it without valgrind it failed
> with memory corruption.

Thanks, we are maybe getting closer. It's weird that it works OK with valgrind. If the valgrind log is empty, though, I'm confused about where the output you pasted below came from.

Show 10 quoted lines

> ==22291== Invalid write of size 1
> ==22291==    at 0x4C2DB93: memcpy@@GLIBC_2.14 (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==22291==    by 0x4076B1: update_pre_post_images (in /usr/lib/git-core/git)
> ==22291==    by 0x40A60F: apply_fragments (in /usr/lib/git-core/git)
> ==22291==    by 0x40C29F: check_patch_list (in /usr/lib/git-core/git)
> ==22291==    by 0x40CC35: apply_patch (in /usr/lib/git-core/git)
> ==22291==    by 0x40F584: cmd_apply (in /usr/lib/git-core/git)
> ==22291==    by 0x4058E7: handle_internal_command (in /usr/lib/git-core/git)
> ==22291==    by 0x404DD1: main (in /usr/lib/git-core/git)

Hmm, it would be nice to have line numbers. Can you try compiling with "-g -O0"?

The function where the problem is deals with whitespace munging. Just a guess, but do you have any whitespace config options set (e.g., apply.whitespace)?

-Peff