git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: fetch --no-tags with and w/o --all

From
Jeff King <peff@peff.net>
Date
Mar 7, 2013, 01:08 UTC
Message-ID
<20130307010829.GB850@sigill.intra.peff.net>
In-Reply-To
<7vhakonirb.fsf@alter.siamese.dyndns.org>
On Wed, Mar 06, 2013 at 04:41:44PM -0800, Junio C Hamano wrote:
Show 5 quoted lines
> > Or we could just pass them through. Looks like this was already fixed by
> > 8556646 (fetch --all: pass --tags/--no-tags through to each remote,
> > 2012-09-05), which is in v1.7.12.2 and higher.
> 
> ;-)  No wonder this looked somewhat familiar.

I still find it somewhat gross that we actually re-construct the command-line from the parsed flag variables. It seems like it would be easier to simply propagate the argv we got in the first place, and then we would not have any chance of omitting a new option that is added later.

Probably not worth worrying about now, though, as the fix is long since shipped. The next person who is adding an option can look at doing that refactoring. And it may be that there are some options we don't propagate intentionally (I didn't look closely).

-Peff
Previous: Junio C Hamano
Message 5 of 5 in “fetch --no-tags with and w/o --all”
  1. Cristian TibirnaMar 6, 2013
  2. Junio C HamanoMar 6, 2013
  3. Jeff KingMar 7, 2013
  4. Junio C HamanoMar 7, 2013
  5. Jeff KingMar 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.