Re: [RFC/WIP PATCH 1/3] teach config parsing to read from strbuf
- From
Jeff King <peff@peff.net>
- Date
- Feb 26, 2013, 04:55 UTC
- Message-ID
- <20130226045552.GA31331@sigill.intra.peff.net>
- In-Reply-To
- <6c69068b4e6a72a2cca5dc6eaffa9982032a7f2a.1361751905.git.hvoigt@hvoigt.net>
On Mon, Feb 25, 2013 at 02:04:18AM +0100, Heiko Voigt wrote:
> This can be used to read configuration values directly from gits > database. > > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
FWIW, I implemented something quite similar as a 2-patch series here:
http://article.gmane.org/gmane.comp.version-control.git/189142
http://article.gmane.org/gmane.comp.version-control.git/189143
but they were never merged as we ended up throwing out the feature built on top (including config from blobs). I didn't look too closely at your implementation, but it looks like you touched the same spots in the same way. Which is probably a good thing, and may give another data point for Junio's "what would it look like to read another source" comment.
-Peff