Re: [PATCH 01/16] git-sh-setup: make usage text consistent
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 24, 2013, 00:25 UTC
- Message-ID
- <20130224002509.GG3222@elie.Belkin>
- In-Reply-To
- <1361665254-42866-2-git-send-email-davvid@gmail.com>
David Aguilar wrote:
Show 7 quoted lines
> mergetool, bisect, and other commands that use > git-sh-setup print a usage string that is inconsistent > with the rest of Git when they are invoked as "git $cmd -h". > > The compiled builtins use the lowercase "usage:" string > but these commands say "Usage:". Adjust the shell library > to make these consistent.
Scripts could be grepping for Usage:, but they are asking for trouble and if anything should check for status 129 instead. And luckily we have been careful about not checking for this in tests. Thanks for the fix.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>