git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/16] git-sh-setup: make usage text consistent

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Feb 24, 2013, 00:25 UTC
Message-ID
<20130224002509.GG3222@elie.Belkin>
In-Reply-To
<1361665254-42866-2-git-send-email-davvid@gmail.com>
David Aguilar wrote:
Show 7 quoted lines
> mergetool, bisect, and other commands that use
> git-sh-setup print a usage string that is inconsistent
> with the rest of Git when they are invoked as "git $cmd -h".
>
> The compiled builtins use the lowercase "usage:" string
> but these commands say "Usage:".  Adjust the shell library
> to make these consistent.

Scripts could be grepping for Usage:, but they are asking for trouble and if anything should check for status 129 instead. And luckily we have been careful about not checking for this in tests. Thanks for the fix.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: David AguilarNext: Jonathan Nieder
Message 18 of 20 in “make usage text consistent in git commands”
  1. 00/16 make usage text consistent in git commandsDavid Aguilar, Feb 24, 2013
  2. 01/16 git-sh-setup: make usage text consistentDavid Aguilar, Feb 24, 2013
  3. 02/16 git-svn: make usage text consistentDavid Aguilar, Feb 24, 2013
  4. 03/16 git-relink: make usage text consistentDavid Aguilar, Feb 24, 2013
  5. 04/16 git-merge-one-file: make usage text consistentDavid Aguilar, Feb 24, 2013
  6. 05/16 git-archimport: make usage text consistentDavid Aguilar, Feb 24, 2013
  7. 06/16 git-cvsexportcommit: make usage text consistentDavid Aguilar, Feb 24, 2013
  8. 07/16 git-cvsimport: make usage text consistentDavid Aguilar, Feb 24, 2013
  9. 08/16 git-cvsimport: make usage text consistentDavid Aguilar, Feb 24, 2013
  10. 09/16 contrib/credential: make usage text consistentDavid Aguilar, Feb 24, 2013
  11. 10/16 contrib/fast-import: make usage text consistentDavid Aguilar, Feb 24, 2013
  12. 11/16 contrib/fast-import/import-zips.py: fix broken error messageDavid Aguilar, Feb 24, 2013
  13. 12/16 contrib/fast-import/import-zips.py: use spaces instead of tabsDavid Aguilar, Feb 24, 2013
  14. 13/16 contrib/examples: make usage text consistentDavid Aguilar, Feb 24, 2013
  15. 14/16 contrib/hooks/setgitperms.perl: make usage text consistentDavid Aguilar, Feb 24, 2013
  16. 15/16 templates/hooks--update.sample: make usage text consistentDavid Aguilar, Feb 24, 2013
  17. 16/16 Documentation/user-manual.txt: make usage text consistentDavid Aguilar, Feb 24, 2013
  18. Jonathan NiederFeb 24, 2013
  19. Jonathan NiederFeb 24, 2013
  20. David AguilarFeb 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.