git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix in Git.pm cat_blob crashes on large files (resubmit

From
Jeff King <peff@peff.net>
Date
Feb 22, 2013, 18:37 UTC
Message-ID
<20130222183703.GC18934@sigill.intra.peff.net>
In-Reply-To
<CAMB+bfLvpKNLaEUyUUYsO5n2y+9tyd_QcnPVzX0s2Z2t3Fr9=g@mail.gmail.com>
On Fri, Feb 22, 2013 at 09:30:57AM -0800, Joshua Clayton wrote:
> Subject: Re: [PATCH] Fix in Git.pm cat_blob crashes on large files
>   (resubmit with reviewed-by)

One thing I forgot to note in my other response: the subject is part of the commit message, so information like "resubmit with..." should go with other cover letter material after the "---".

It's also customary to say something like "PATCHv2" in the brackets (which does get stripped off), and mention what is changed since v1 after the "---". That can help reviewers remember what happened, and it can help the maintainer understand where in the process of review the patch is.

-Peff
Previous: Joshua ClaytonNext: Junio C Hamano
Message 4 of 5 in “Fix in Git.pm cat_blob crashes on large files (resubmit with reviewed-by)”
  1. Fix in Git.pm cat_blob crashes on large files (resubmit with reviewed-by)Joshua Clayton, Feb 22, 2013
  2. Jeff KingFeb 22, 2013
  3. Joshua ClaytonFeb 22, 2013
  4. Jeff KingFeb 22, 2013
  5. Junio C HamanoFeb 22, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.