Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 18, 2013, 10:15 UTC
- Message-ID
- <20130218101523.GD7049@elie.Belkin>
- In-Reply-To
- <20130218092221.GD5096@sigill.intra.peff.net>
Jeff King wrote:
Show 9 quoted lines
> --- a/pkt-line.c
> +++ b/pkt-line.c
> @@ -160,7 +160,8 @@ static int packet_read_internal(int fd, char *buffer, unsigned size, int gently)
> }
> len -= 4;
> if (len >= size)
> - die("protocol error: bad line length %d", len);
> + die("protocol error: line too large: (expected %u, got %d)",
> + size, len);Makes sense. I think this should say "expected < %u, got %d", since we don't actually expect most lines to be 1004 bytes in practice.
With or without such a change, Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>