Re: [PATCH] completion: support 'git config --local'

From: Jeff King <peff@peff.net>
Date: Feb 13, 2013, 00:05 UTC
Message-ID: <20130213000519.GA31758@sigill.intra.peff.net>
In-Reply-To: <7v1uclfafi.fsf@alter.siamese.dyndns.org>

On Tue, Feb 12, 2013 at 02:13:05PM -0800, Junio C Hamano wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I'm not sure I understand the original poster's point about "git config
> > -l --local". "-l" does not take a limiter, does it?
> 
> "git config -l core.\*" will just die without limiting the output to
> everything under core. hierarchy, so you are right---the combination
> does not make any sense.  You have to say
> 
>     git config -l | grep ^core\\.
> 
> or something like that.
> 
> Completing "git config -l --lo<TAB>" still may help, though.

Ah, I think I see Dasa's original point now. He was interested in fixing "--lo<TAB>" to complete "--local". But the line he pointed to in his original message is not the right place for that; it is the site of an unrelated spot which should _also_ be fixed to use "--local", but for a different reason (restricting the variables suggested for "--local --get <TAB>" properly).

So yeah. Matthieu's patch is the right thing to do, as it covers both (mine fixed only half of it).

-Peff